src: support multiple versions in node.config.json by marco-ippolito · Pull Request #63033 · nodejs/node

marco-ippolito · 2026-04-29T10:16:23Z

This PR updates the config file support with runtime version checks and multi-configurations based on version.

A config file can now declare nodeVersion to ensure it only applies to the matching Node.js major version. It can also use a top-level configs array to store multiple version-specific configs in the same file. Node.js selects the first entry whose nodeVersion matches the current runtime.
The version matches the major version, I dont think we need to be verify minor and patch

nodejs-github-bot · 2026-04-29T10:16:29Z

Review requested:

@nodejs/config

Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com>

codecov · 2026-04-29T11:53:16Z

Codecov Report

❌ Patch coverage is 62.56410% with 73 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.64%. Comparing base (8173251) to head (f2d182c).
⚠️ Report is 69 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/options.js	0.00%	55 Missing ⚠️
src/node_config_file.cc	87.14%	11 Missing and 7 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #63033      +/-   ##
==========================================
- Coverage   91.49%   89.64%   -1.86%     
==========================================
  Files         358      708     +350     
  Lines      151574   220543   +68969     
  Branches    23921    42295   +18374     
==========================================
+ Hits       138679   197697   +59018     
- Misses      12619    14686    +2067     
- Partials      276     8160    +7884

Files with missing lines	Coverage Δ
src/node_config_file.h	`100.00% <ø> (ø)`
src/node_config_file.cc	`84.14% <87.14%> (ø)`
lib/internal/options.js	`35.84% <0.00%> (-10.76%)`	⬇️

... and 470 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot · 2026-05-05T19:54:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/73183/

nodejs-github-bot · 2026-05-06T06:19:44Z

Commit Queue failed

- Loading data for nodejs/node/pull/63033
✔  Done loading data for nodejs/node/pull/63033
----------------------------------- PR info ------------------------------------
Title      src: support multiple versions in node.config.json (#63033)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     marco-ippolito:more-work-config-file -> nodejs:main
Labels     c++, lib / src, needs-ci, review wanted
Commits    2
 - src: support multiple versions in node.config.json
 - doc: document the latest-vX.x schema
Committers 1
 - Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/63033
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/63033
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 29 Apr 2026 10:16:23 GMT
   ✔  Approvals: 1
   ✔  - Pietro Marchini (@pmarchini): https://github.com/nodejs/node/pull/63033#pullrequestreview-4229807108
   ✘  This PR needs to wait 4 more hours to land (or 0 minutes if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-05-05T19:54:30Z: https://ci.nodejs.org/job/node-test-pull-request/73183/
- Querying data for job/node-test-pull-request/73183/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/25419716012

nodejs-github-bot · 2026-05-06T16:53:01Z

Commit Queue failed

- Loading data for nodejs/node/pull/63033 ✔ Done loading data for nodejs/node/pull/63033 ----------------------------------- PR info ------------------------------------ Title src: support multiple versions in node.config.json (#63033) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch marco-ippolito:more-work-config-file -> nodejs:main Labels c++, lib / src, needs-ci, review wanted Commits 2 - src: support multiple versions in node.config.json - doc: document the latest-vX.x schema Committers 1 - Marco Ippolito <marcoippolito54@gmail.com> PR-URL: https://github.com/nodejs/node/pull/63033 Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/63033 Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 29 Apr 2026 10:16:23 GMT ✔ Approvals: 2 ✔ - Pietro Marchini (@pmarchini): https://github.com/nodejs/node/pull/63033#pullrequestreview-4229807108 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/63033#pullrequestreview-4237600552 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2026-05-06T06:19:44Z: https://ci.nodejs.org/job/node-test-pull-request/73183/ - Querying data for job/node-test-pull-request/73183/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 63033 From https://github.com/nodejs/node * branch refs/pull/63033/merge -> FETCH_HEAD ✔ Fetched commits as e80b5d2ab211..f2d182ce354d -------------------------------------------------------------------------------- Auto-merging doc/api/cli.md Auto-merging src/node_config_file.cc Auto-merging test/parallel/test-config-file.js [main a9c54e2e3d] src: support multiple versions in node.config.json Author: Marco Ippolito <marcoippolito54@gmail.com> Date: Wed Apr 29 11:59:55 2026 +0200 6 files changed, 1610 insertions(+), 1040 deletions(-) Auto-merging doc/api/cli.md [main 18d4827b1e] doc: document the latest-vX.x schema Author: Marco Ippolito <marcoippolito54@gmail.com> Date: Wed Apr 29 12:18:20 2026 +0200 1 file changed, 2 insertions(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. (node:362) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated. (Use `node --trace-deprecation ...` to show where the warning was created) Rebasing (2/4)

�[KExecuting: git node land --amend --yes
--------------------------------- New Message ----------------------------------
src: support multiple versions in node.config.json

Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #63033
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

[detached HEAD a10ff2bce1] src: support multiple versions in node.config.json
Author: Marco Ippolito <marcoippolito54@gmail.com>
Date: Wed Apr 29 11:59:55 2026 +0200
6 files changed, 1610 insertions(+), 1040 deletions(-)
Rebasing (3/4)
Rebasing (4/4)

�[KExecuting: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: document the latest-vX.x schema

Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #63033
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

[detached HEAD ec8ad76ace] doc: document the latest-vX.x schema
Author: Marco Ippolito <marcoippolito54@gmail.com>
Date: Wed Apr 29 12:18:20 2026 +0200
1 file changed, 2 insertions(+), 1 deletion(-)

�[KSuccessfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/25448865776

nodejs-github-bot · 2026-05-06T17:28:03Z

Landed in c52fad3...1800049

Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com> PR-URL: #63033 Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

ljharb · 2026-05-06T17:50:12Z

ftr you will definitely need to check the minor version, since new config options could be added in a minor.

marco-ippolito · 2026-05-08T06:04:18Z

ftr you will definitely need to check the minor version, since new config options could be added in a minor.

Who's running the same config against multiple minor versions? The most common use case for package author is to run against multiple majors

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Apr 29, 2026

marco-ippolito force-pushed the more-work-config-file branch from a40a7dc to 5651e9d Compare April 29, 2026 10:18

marco-ippolito added 2 commits April 29, 2026 12:23

src: support multiple versions in node.config.json

39db6a0

Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com>

doc: document the latest-vX.x schema

f2d182c

Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com>

marco-ippolito force-pushed the more-work-config-file branch from 5651e9d to f2d182c Compare April 29, 2026 10:24

marco-ippolito added the review wanted PRs that need reviews. label May 4, 2026

pmarchini reviewed May 5, 2026

View reviewed changes

Comment thread test/parallel/test-config-file.js

pmarchini approved these changes May 5, 2026

View reviewed changes

marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label May 5, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 5, 2026

marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label May 6, 2026

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 6, 2026

jasnell approved these changes May 6, 2026

View reviewed changes

marco-ippolito added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels May 6, 2026

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 6, 2026

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 6, 2026

nodejs-github-bot closed this May 6, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

src: support multiple versions in node.config.json#63033

src: support multiple versions in node.config.json#63033
marco-ippolito wants to merge 2 commits intonodejs:mainfrom
marco-ippolito:more-work-config-file

marco-ippolito commented Apr 29, 2026

Uh oh!

nodejs-github-bot commented Apr 29, 2026

Uh oh!

codecov Bot commented Apr 29, 2026 •

edited

Loading

Uh oh!

Uh oh!

nodejs-github-bot commented May 5, 2026

Uh oh!

nodejs-github-bot commented May 6, 2026

Uh oh!

nodejs-github-bot commented May 6, 2026

Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #63033
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #63033
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

�[KSuccessfully rebased and updated refs/heads/main.

Uh oh!

nodejs-github-bot commented May 6, 2026

Uh oh!

ljharb commented May 6, 2026

Uh oh!

marco-ippolito commented May 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

marco-ippolito commented Apr 29, 2026

Uh oh!

nodejs-github-bot commented Apr 29, 2026

Uh oh!

codecov Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

nodejs-github-bot commented May 5, 2026

Uh oh!

nodejs-github-bot commented May 6, 2026

Uh oh!

nodejs-github-bot commented May 6, 2026

Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com> PR-URL: #63033 Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com> PR-URL: #63033 Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

�[KSuccessfully rebased and updated refs/heads/main.

Uh oh!

nodejs-github-bot commented May 6, 2026

Uh oh!

ljharb commented May 6, 2026

Uh oh!

marco-ippolito commented May 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov Bot commented Apr 29, 2026 •

edited

Loading

Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #63033
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #63033
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>